Fixed RTX 2070 Gaming OC detection #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First of all, GitLab is the place to open MRs. GitHub is just a mirror. Second, your GPU is most likely a variant and by replacing it, you are removing another. Check the the Git commit history for it on GitLab and see if it was tested, and add it as additional entry if that is the case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Gigabyte RTX 2070 Gaming OC is not detected by OpenRGB because the GPU DEV ID was written incorrectly in the detector. Replacing NVIDIA_RTX2070_DEV with NVIDIA_RTX2070_OC_DEV solved this problem (tested with own build)